The effect of colloidal bismuth subcitrate (De-Nol) on symptoms, Helicobacter pylori status and histological features was studied in 35 patients with non-ulcer dyspepsia. Pain (34 cases) and gas bloat (18) were the predominant symptoms. H pylori was present in 26 (74.3%) patients. Gastritis and duodenitis were present in 29 of 32 and 22 of 31 cases respectively in whom biopsies were available. Relief in symptoms after treatment was seen in 29 (82.8%) cases. Improvement in gastritis and duodenitis was noted in 60.8% and 58.8% respectively; over 70% of H pylori positive patients cleared the organism. These changes did not correlate with the relief in symptoms. We conclude that colloidal bismuth subcitrate is effective in the short term treatment of non-ulcer dyspepsia. It also clears H pylori infection and results in improvement of histological features.